Allow using a custom resolver function on DjangoConnectionField #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb1511
force-pushed
the
fix-connection-field-custom-resolver
branch
from
a1cc52c to
5436a28
Compare
mb1511
force-pushed
the
fix-connection-field-custom-resolver
branch
from
5436a28 to
9e6fc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue the other day trying to add a custom resolver function to a
DjangoConnectionField:In this case the
some_resolverfunction is simply ignored.We managed to work around it by defining the resolver on the query using the default
def resolve_{field}:pattern and just linked that to return the result of the function we wanted to use.Admittedly, its a pretty niche use case, but still thought it would be nice to try and fix.